* Carlos Aguiar <carlos.aguiar@xxxxxxxxxxx> [080128 07:59]: > From: Carlos Eduardo Aguiar <carlos.aguiar@xxxxxxxxxxx> > > This simple patch fix some TWL4030 failures and makes MMC work properly on 2430 boards. > > As noted by Chandra, this check for 2430 or 3430 is needed because CONFIG_I2C_TWL4030_ID > set to 2 will break 3430 boards. > > Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@xxxxxxxxxxx> > Signed-off-by: Madhusudhan Chikkature <madhu.cr@xxxxxx> > Signed-off-by: Chandra shekhar <x0044955@xxxxxx> > Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx> > --- > drivers/i2c/chips/twl4030_core.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/chips/twl4030_core.c b/drivers/i2c/chips/twl4030_core.c > index e733195..4d7f8f9 100644 > --- a/drivers/i2c/chips/twl4030_core.c > +++ b/drivers/i2c/chips/twl4030_core.c > @@ -130,7 +130,11 @@ > #define HIGH_PERF_SQ (1 << 3) > > /* on I2C-1 for 2430SDP */ > +#ifdef CONFIG_MACH_OMAP_3430SDP > #define CONFIG_I2C_TWL4030_ID 1 > +#elif CONFIG_MACH_OMAP_2430SDP > +#define CONFIG_I2C_TWL4030_ID 2 > +#endif > > /* Helper functions */ > static int Please change the code to get the chip id from i2c_board_info in board-*.c files. Otherwise we're again adding a blocker for compiling in multiple omap2 boards. I believe addr in i2c_board_info is the field to use for this. Regards, Tony - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html