Hi Vikram
On Fri, 25 Jan 2008, Pandita, Vikram wrote:
> DPLL5 enabling should be made part of CM/PRM framework. It should be
> enabled upfront or tied to 120m clk and put in autoidle mode and in that
> sense USB should not care about DPLL5. Since the framework does not have
> it now, I have put it in USB code.
I agree completely with all of this, and the DPLL enable & disable code
should be complete soon, but am suggesting that, in the interim before
it's posted, if your driver needs to use CM or PRM registers, that it use
the existing support and register defines for this via
{cm,prm}_{read,write}_{,mod}_reg()
> >> Index: omap-submit/drivers/usb/host/ehci-omap.h
> >> ===================================================================
> >>
> >> +/* PRCM: CLOCK_Control_CM */
> >> +#define PM_PREPWSTST_USBHOST\
> >> + (OMAP2_PRM_BASE + OMAP3430ES2_USBHOST_MOD + OMAP3430_PM_PREPWSTST)
> >
> >Please use what's defined in the CM and PRM include files here. Defining
> >new macros there if needed.
>
> Are there any exported header files for this? I think all files are
> present in arch/arm/mach-omap2/ and how will any driver access the .h?
You've already got sideways includes up higher in ehci-omap.h for cm.h and
prm.h. So for the time being perhaps you can just add a few more for
{prm,cm}_regbits_34xx.h. Looks like those files should be moved to
include/asm-arm/arch-omap...
- Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
