On Fri, 2008-01-18 at 09:55 -0800, Tony Lindgren wrote:
> * Daniel Walker <dwalker@xxxxxxxxxx> [080118 09:37]:
> > >
> > > In general, we should feed all the fixes we can during the release
> > > cycle, so let's get more active on that part too.
> >
> > Would you consider checkpatch.pl cleanups in that catagory?
>
> Well I guess it depends. Any bigger clean-up patches would be better
> done after we're in sync with mainline. But anything that can be
> justified as a fix and does not generate extra noise sure.
checkpatch.pl cleanups would be more like what some might consider
noise .. Here's a sample on the board-nokia770.c
$ ./scripts/checkpatch.pl --file arch/arm/mach-omap1/board-nokia770.c
WARNING: line over 80 characters
#137: FILE: arm/mach-omap1/board-nokia770.c:137:
+static struct ads7846_platform_data nokia770_ads7846_platform_data __initdata = {
WARNING: printk() should include KERN_ facility level
#278: FILE: arm/mach-omap1/board-nokia770.c:278:
+ printk("HP connected\n");
total: 0 errors, 2 warnings, 394 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
> Thanks, looks like the old include is still in the omap1-branch too, here's
> a modified version of the patch to fix it there and avoid the extra
> ifdef.
It looks fine to me ..
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
