On Monday 07 January 2008, Felipe Balbi wrote: > On Mon, Jan 07, 2008 at 10:20:38AM +0200, Jarkko Nikula wrote: > > > > How about passing h2_i2c_board_info via omap_register_i2c_bus? > > > > ... > > > > @@ -551,7 +549,8 @@ static void __init h2_init(void) > > omap_board_config = h2_config; > > omap_board_config_size = ARRAY_SIZE(h2_config); > > omap_serial_init(); > > - omap_register_i2c_bus(1, 100, NULL, 0); > > + omap_register_i2c_bus(1, 100, h2_i2c_board_info, > > + ARRAY_SIZE(h2_i2c_board_info)); > > h2_mmc_init(); > > omap_register_gpio_switches(h2_gpio_switches, > > ARRAY_SIZE(h2_gpio_switches)); > > i2c_register_bard_info() looks better to me since it's comming from i2c > subsystem. Maybe we should, instead, get rid of omap_register_i2c_bus > when we finish porting all omap i2c drivers to new style i2c. I think it'd be be better to do this with the omap_register_i2c_bus() call, since that's why the vector is provided with that call in the first place. It's one-stop shopping for setting up that bus: mux the pins, set up its default speed, register its devices. Requiring two separate calls would be *less* clear. And more error prone ... shown by several patches preceding this one from Jarkko!! - Dave - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
