Re: [PATCH 1/1] ARM: OMAP: Fix kernel panic on I2C when booting TI H2 boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 02, 2008 at 03:15:26PM -0400, Carlos Aguiar wrote:
> From: Carlos Eduardo Aguiar <carlos.aguiar@xxxxxxxxxxx>
> 
> This patch adds on arch/arm/mach-omap1/board-h2.c file,
> the i2c_register_board_info() call at h2_init(void),
> in order to fix kernel panic on I2C when booting TI H2 boards.
> 
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@xxxxxxxxxxx>
Acked-by: Felipe Balbi <me@xxxxxxxxxxxxxxx>

> ---
>  arch/arm/mach-omap1/board-h2.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
> index 43f9627..007a00b 100644
> --- a/arch/arm/mach-omap1/board-h2.c
> +++ b/arch/arm/mach-omap1/board-h2.c
> @@ -447,8 +447,6 @@ static void __init h2_init_irq(void)
>  	omap1_init_common_hw();
>  	omap_init_irq();
>  	omap_gpio_init();
> -	i2c_register_board_info(1, h2_i2c_board_info,
> -				ARRAY_SIZE(h2_i2c_board_info));
>  	h2_init_smc91x();
>  }
>  
> @@ -545,6 +543,9 @@ static void __init h2_init(void)
>  	}
>  #endif
>  
> +	i2c_register_board_info(1, h2_i2c_board_info,
> +				ARRAY_SIZE(h2_i2c_board_info));
> +

Good catch. I just compile tested on H2 and H4 and let it pass. Sorry
guys

>  	platform_add_devices(h2_devices, ARRAY_SIZE(h2_devices));
>  	spi_register_board_info(h2_spi_board_info,
>  				ARRAY_SIZE(h2_spi_board_info));
> -- 1.5.3.GIT
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Best Regards,

Felipe Balbi
me@xxxxxxxxxxxxxxx
http://blog.felipebalbi.com
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux