Hi Arnaud,
Thanks for your collaboration. I've some points on your patch:
On Dec 18, 2007 9:34 AM, Rtp Arnaud Patard <arnaud.patard@xxxxxxxxxxx> wrote:
> Adds mmc multislot support for Nokia 770 machines. Without this, I can't
> use the MMC slot at all. Also, I had to hardcode some GPIO pin values as
> it's not really easy to use the ones from the OMAP_TAG_MMC ATAG in
> places like the set_power() hook.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>
> ---
>
First, try using scripts/checkpatch.pl script. It is a handy tool.
Here is its output for your patch:
./scripts/checkpatch.pl patches/n770_mmc_multi_slot1.patch
WARNING: externs should be avoided in .c files
#44: FILE: arch/arm/mach-omap1/board-nokia770.c:379:
+extern void __init nokia770_mmc_init(void);
WARNING: line over 80 characters
#54: FILE: arch/arm/mach-omap1/board-nokia770.c:397:
+ omap_register_gpio_switches(nokia770_gpio_switches,ARRAY_SIZE(nokia770_gpio_switches));
ERROR: need space after that ',' (ctx:VxV)
#54: FILE: arch/arm/mach-omap1/board-nokia770.c:397:
+ omap_register_gpio_switches(nokia770_gpio_switches,ARRAY_SIZE(nokia770_gpio_switches));
^
ERROR: Missing Signed-off-by: line(s)
total: 2 errors, 2 warnings, 163 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Of course, you may ignore some of them (like that one about the
signed-off-by). BTW, using git to generate your patches would help
too.
I believe you can use static inline on these functions:
+
+static void nokia770_mmc_cleanup(struct device *dev)
+{
+}
+
+void __init nokia770_mmc_init(void)
+{
+}
+
+void nokia770_mmc_slot_cover_handler(void *arg, int state)
+{
+}
BR,
--
Eduardo Bezerra Valentin
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
