>From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Paul >Walmsley >Sent: Wednesday, December 19, 2007 2:10 PM >To: linux-omap@xxxxxxxxxxxxxxx >Subject: [PATCH 0/3] 3430 clock: add several 3430ES2-only clocks > >Hello, > >These patches add several OMAP3430 ES2 clocks and clock rates. To do >so in a way that works on either ES1 or ES2 at runtime, we need to >specially mark the clocks and rates that are specific to one or the >other revision. This allows us to skip configuring those clocks at >boot. > >Boot-tested on 3430SDP ES1. Comments welcomed. Your patches break booting on ES2.0 You may have to reconsider the changes given that it causes a kernel panic on bootup on ES2.0 Following is the log for reference: Uncompressing Linux................................................................................. .............. done, booting the kernel. <5>Linux version 2.6.24-rc5-omap1-g047c6b0c-dirty (vikram@xxxxxxxxxxxxxxxxxxxxx) (gcc version 4.1.1 (CodeSourcery ARM Sourcery G++ 2006q3-26)) #43 Wed Dec 19 17:47:09 IST 2007 CPU: ARMv7 Processor [411fc081] revision 1 (ARMv7), cr=00c5387f Machine: OMAP3430 3430SDP board Memory policy: ECC disabled, Data cache writeback <7>On node 0 totalpages: 32768 <7> DMA zone: 256 pages used for memmap <7> DMA zone: 0 pages reserved <7> DMA zone: 32512 pages, LIFO batch:7 <7> Normal zone: 0 pages used for memmap <7> Movable zone: 0 pages used for memmap <6>OMAP3430ES1 <6>SRAM: Mapped pa 0x40200000 to va 0xd7000000 size: 0x100000 CPU0: D VIPT write-through cache CPU0: cache: 768 bytes, associativity 1, 8 byte lines, 64 sets Built 1 zonelists in Zone order, mobility grouping on. Total pages: 32512 <5>Kernel command line: console=ttyS0,115200n8 noinitrd root=/dev/nfs rw nfsroot=172.24.190.242:/dat a/12X_FS/targetaudio,nolock,rsize=400,wsize=400,tcp ip=dhcp devfs=mount <1>Unable to handle kernel NULL pointer dereference at virtual address 0000000c <1>pgd = c0004000 <1>[0000000c] *pgd=00000000 Internal error: Oops: 5 [#1] Modules linked in: CPU: 0 Not tainted (2.6.24-rc5-omap1-g047c6b0c-dirty #43) PC is at omap2_get_clksel_by_parent+0x38/0x54 LR is at omap2_clksel_to_divisor+0x20/0x90 pc : [<c002e964>] lr : [<c002e9a0>] psr: 600001d3 sp : c02bfee8 ip : c02bfef8 fp : c02bfef4 r10: 0000001f r9 : 411fc081 r8 : 800205a4 r7 : c02c1d68 r6 : 00000002 r5 : c02c52f4 r4 : 00000002 r3 : 00000000 r2 : c02c52f4 r1 : 00000000 r0 : c02263c0 Flags: nZCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment kernel Control: 00c5387f Table: 80004018 DAC: 00000017 Process swapper (pid: 0, stack limit = 0xc02be2d8) Stack: (0xc02bfee8 to 0xc02c0000) fee0: c02bff14 c02bfef8 c002e9a0 c002e938 c02bff3c 00000002 ff00: c02c52f4 c0021f28 c02bff34 c02bff18 c002f15c c002e98c c0224464 00000007 ff20: c02c52f4 48000000 c02bff4c c02bff38 c002f26c c002f11c c02c82dc c02c52f4 ff40: c02bff64 c02bff50 c003acf4 c002f260 c0011820 c0022830 c02bff8c c02bff68 ff60: c0011870 c003acc4 c02c0100 fffffff8 c02bff8c c02e32a4 c02e32b0 c0021f28 ff80: c02bff9c c02bff90 c00110e8 c00117e8 c02bffb4 c02bffa0 c00119c0 c00110e0 ffa0: 00000060 c02e32a4 c02bffc4 c02bffb8 c000ee18 c00119b8 c02bfff4 c02bffc8 ffc0: c0008c5c c000edec c0008544 00000000 00000000 c0021f28 00000000 00c5387d ffe0: c02e3bb0 c002232c 00000000 c02bfff8 80008034 c0008b18 00000000 00000000 Backtrace: [<c002e92c>] (omap2_get_clksel_by_parent+0x0/0x54) from [<c002e9a0>] (omap2_clksel_to_divisor+0x20/0 x90) [<c002e980>] (omap2_clksel_to_divisor+0x0/0x90) from [<c002f15c>] (omap2_clksel_get_divisor+0x4c/0x5 c) r6:c0021f28 r5:c02c52f4 r4:00000002 [<c002f110>] (omap2_clksel_get_divisor+0x0/0x5c) from [<c002f26c>] (omap2_clksel_recalc+0x18/0x58) r5:48000000 r4:c02c52f4 [<c002f254>] (omap2_clksel_recalc+0x0/0x58) from [<c003acf4>] (recalculate_root_clocks+0x3c/0x5c) r4:c02c52f4 [<c003acb8>] (recalculate_root_clocks+0x0/0x5c) from [<c0011870>] (omap2_clk_init+0x94/0x140) r4:c0022830 [<c00117dc>] (omap2_clk_init+0x0/0x140) from [<c00110e8>] (omap2_init_common_hw+0x14/0x20) r6:c0021f28 r5:c02e32b0 r4:c02e32a4 [<c00110d4>] (omap2_init_common_hw+0x0/0x20) from [<c00119c0>] (omap_3430sdp_init_irq+0x14/0x9c) [<c00119ac>] (omap_3430sdp_init_irq+0x0/0x9c) from [<c000ee18>] (init_IRQ+0x38/0x48) [<c000ede0>] (init_IRQ+0x0/0x48) from [<c0008c5c>] (start_kernel+0x150/0x2b4) [<c0008b0c>] (start_kernel+0x0/0x2b4) from [<80008034>] (0x80008034) r6:c002232c r5:c02e3bb0 r4:00c5387d Code: e2800008 e5903000 e3530000 1afffff9 (e591100c) <0>Kernel panic - not syncing: Attempted to kill the idle task! > > >- Paul > >diffstat: > arch/arm/mach-omap2/clock24xx.h | 2 > arch/arm/mach-omap2/clock34xx.c | 16 + > arch/arm/mach-omap2/clock34xx.h | 331 ++++++++++++++++++++++++++++++--- > arch/arm/mach-omap2/cm.h | 6 > arch/arm/mach-omap2/cm_regbits_34xx.h | 101 +++++++--- > arch/arm/mach-omap2/prcm_common.h | 10 > arch/arm/mach-omap2/prm_regbits_34xx.h | 7 > include/asm-arm/arch-omap/clock.h | 16 - > 8 files changed, 429 insertions(+), 60 deletions(-) > >size: > text data bss dec hex filename >2862858 147344 96312 3106514 2f66d2 vmlinux.3430sdp.orig >2863882 148856 96312 3109050 2f70ba vmlinux.3430sdp.patched > >- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html