Hi Kevin,
On Tue, 11 Dec 2007, Kevin Hilman wrote:
> arch/arm/mach-omap2/clock.c | 8 +++++++-
>
> @@ -211,7 +212,6 @@ static void omap2_clk_wait_ready(struct clk *clk)
> else
> return;
>
> - /* REVISIT: What are the appropriate exclusions for 34XX? */
> /* No check for DSS or cam clocks */
> if (cpu_is_omap24xx() && ((u32)reg & 0x0f) == 0) { /* CM_{F,I}CLKEN1 */
> if (clk->enable_bit == OMAP24XX_EN_DSS2_SHIFT ||
> @@ -220,6 +220,12 @@ static void omap2_clk_wait_ready(struct clk *clk)
> return;
> }
>
> + /* REVISIT: What are the appropriate exclusions for 34XX? */
> + /* OMAP3: ignore DSS-mod clocks */
> + if (cpu_is_omap34xx() &&
> + (((u32)reg & ~0xff) == (u32)OMAP_CM_REGADDR(OMAP3430_DSS_MOD, 0)))
> + return;
> +
> /* Check if both functional and interface clocks
> * are running. */
> bit = 1 << clk->enable_bit;
The code part of this comment looks okay, but since there are other
exclusions besides DSS (for each module that can be a L3 interconnect
initiator), we should probably leave the REVISIT: comments in for now
until those go in.
- Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
