Re: [PATCH] ARM: OMAP: Use the correct CONFIG_ARCH_OMAP24XX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Kevin Hilman <khilman@xxxxxxxxxx> [071206 10:50]:
> Kyungmin Park <kyungmin.park@xxxxxxxxxxx> writes:
> 
> > Use the correct CONFIG_ARCH_OMAP24XX.
> > It boots on locked SRAM board.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > ---
> > diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> > index afe8181..6305dc9 100644
> > --- a/arch/arm/plat-omap/sram.c
> > +++ b/arch/arm/plat-omap/sram.c
> > @@ -91,7 +91,7 @@ static int is_sram_locked(void)
> >  {
> >  	int type = 0;
> >  
> > -#if defined(CONFIG_ARCH_OMAP242X)
> > +#if defined(CONFIG_ARCH_OMAP24XX)
> >  	if (cpu_is_omap242x())
> >  		type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
> >  			OMAP2_DEVICETYPE_MASK);
> 
> Shouldn't the cpu_is_omap242x be changed to cpu_is_omap24xx also so
> this works on 2430?

Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be
needed here. If not selected, the cpu_is_omapxxxx() functions
are if (0) {} functions and get optimized out.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux