Hi Anand,
On Dec 12, 2007 12:10 AM, Gadiyar, Anand <gadiyar@xxxxxx> wrote:
> > From: Felipe Balbi <felipe.lima@xxxxxxxxxxx>
> >
> > CONTROL_DEVCONF0 has changed to OMAP2_CONTROL_DEVCONF0. Fixes
> > in omap_udc.c the use of such macro.
> >
> > Signed-off-by: Felipe Balbi <felipe.lima@xxxxxxxxxxx>
> > ---
> > drivers/usb/gadget/omap_udc.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/omap_udc.c
> > b/drivers/usb/gadget/omap_udc.c
> > index 2e8775e..e197900 100644
> > --- a/drivers/usb/gadget/omap_udc.c
> > +++ b/drivers/usb/gadget/omap_udc.c
> > @@ -2272,7 +2272,7 @@ static int proc_otg_show(struct seq_file *s)
> > * do with the frame adjustment counter and McBSP2.
> > */
> > ctrl_name = "control_devconf";
> > - trans = ctrl_read_reg(CONTROL_DEVCONF0);
> > + trans = omap_readl(OMAP2_CONTROL_DEVCONF0);
>
> Shouldn't this be
> + trans = ctrl_read_reg(OMAP2_CONTROL_DEVCONF0);
I believe Balbi changed the function call because the read/write
methods for ctrl register is not
exported anymore. If you check under arch/arm/mach-omap2/control.h,
they are static. Of course,
we can change it to be exported, but with this patch it just do not
touch the api.
That's my 2c...
>
>
> > } else {
> > ctrl_name = "tranceiver_ctrl";
> > trans = USB_TRANSCEIVER_CTRL_REG;
> > --
> > 1.5.3.7.1149.g591a
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-omap" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> -
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Eduardo Bezerra Valentin
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
