On Tue, Dec 11, 2007 at 06:20:36PM +0530, ext Gadiyar, Anand wrote: > > > > > Index: linux-omap/arch/arm/mach-omap2/board-3430sdp-usb.c > > > > > > > =================================================================== > > > > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > > > > > +++ linux-omap/arch/arm/mach-omap2/board-3430sdp-usb.c > > > <snip> > > > > > +#include <linux/types.h> > > > > > +#include <linux/errno.h> > > > > > +#include <linux/delay.h> > > > > > +#include <linux/platform_device.h> > > > > > +#include <linux/usb/musb.h> > > > > > + > > > > > +#include <asm/arch/hardware.h> > > > > > +#include <asm/arch/usb.h> > > > > > + > > > > > +#if defined(CONFIG_USB_MUSB_HDRC) || > > > > defined(CONFIG_USB_MUSB_HDRC_MODULE) > > > > > > > > What about #ifdef CONFIG_USB_MUSB_SOC > > > > > > > > > > How is this relevant? Could you please elaborate? > > > > #if defined(*) || defined(*_MODULE) looks a bit awkward. > > CONFIG_USB_MUSB_SOC is a boolean macro and is true in 2430 and 34XX. > > > > Anybody has any comments on this ?? > > I might end up doing this in other places as well. > Specifically, when adding EHCI, I might have something along the lines of > > #if defined (CONFIG_USB_EHCI_HCD) || defined (CONFIG_USB_EHCI_HCD_MODULE) > > Besides, it seems to be common usage anywhere you have something that can > be built as a module. > > grep -r CONFIG | grep MODULE | grep "#if" | wc -l > returns something like 900+ results ;) Ok then... that's fine to me ;-) > > > > > > > > > > > > > > > > > Index: linux-omap/arch/arm/mach-omap2/board-3430sdp.c > > > > > > > =================================================================== > > > > > --- linux-omap.orig/arch/arm/mach-omap2/board-3430sdp.c > > > > 2007-12-05 > > > > > 10:02:53.000000000 +0530 > > > > > +++ linux-omap/arch/arm/mach-omap2/board-3430sdp.c > > 2007-12-05 > > > > > 17:04:09.664182922 +0530 > > > > > @@ -307,6 +307,8 @@ > > > > > return 0; > > > > > } > > > > > > > > > > +extern void __init sdp3430_usb_init(void); > > > > > > > > This extern will look better in > > > > include/asm-arm/arch-omap/board-3430sdp.h > > > > > > Yes. But there are other .c files in arch/arm/mach-omap2 > > that declare externs. > > > Specifically, board-2430sdp.c also does it this way. I > > thought it would be a > > > good idea to retain the same structure. > > > > > > I can move it to the .h file if needed. What do you think? > > > > Don't know about the others, but I'd prefer seeing this > > prototype in the > > header file. > > > > Ok. No problem moving it to the .h file. Anyone else thinks this way? > > Also what about the other externs in board*.c files? > > Best Regards, > Anand -- Best Regards, Felipe Balbi felipe.lima@xxxxxxxxxxx +55 92 2126-1003 INdT - OSMRC - Manaus Core Team - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
