* david.cohen@xxxxxxxxxxx <david.cohen@xxxxxxxxxxx> [071205 11:59]: > From: David Cohen <david.cohen@xxxxxxxxxxx> > > OMAP2420 has a different offset for CONTROL_STATUS register. > > Signed-off-by: David Cohen <david.cohen@xxxxxxxxxxx> > --- > include/asm-arm/arch-omap/control.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/asm-arm/arch-omap/control.h b/include/asm-arm/arch-omap/control.h > index 5f42725..8670d54 100644 > --- a/include/asm-arm/arch-omap/control.h > +++ b/include/asm-arm/arch-omap/control.h > @@ -37,7 +37,13 @@ > > #define CONTROL_DEVCONF0 (CONTROL_GENERAL + 0x04) > #define CONTROL_DEVCONF1 (CONTROL_GENERAL + 0x68) /* > 242x */ > + > +/* OMAP2420's CONTROL_STATUS offset is 0x2F8 */ > +#ifdef CONFIG_ARCH_OMAP2420 > +#define CONTROL_STATUS (CONTROL_GENERAL + 0x88) > +#else > #define CONTROL_STATUS (CONTROL_GENERAL + 0x80) > +#endif > Please no more ifdefs in headers for 24XX vs 3440. Instead, please define OMAP2420_CONTROL_STATUS and OMAP2430_CONTROL_STATUS or something like that. Regards, Tony - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html