On Wed, Jun 25, 2008 at 11:54:53AM -0500, Paul Jackson wrote: > > If not, why do we want it to be included in every object file? > > The extern storage class keyword is essentially optional in the case of > file level data declarations. Only one instance of the variable ends > up, in the .bss section, of the final executable. For a header file like numa.h it's reasonable to support the case of it being included, but libnuma not actually being linked. In that case an unnecessary variable is added to the executable. Also it's confusing when you look at the object files with nm or similar. I would add the extern. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-numa" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html