Some nice patches, Andi. Thanks.
One detail doesn't seem right to me however.
Andi wrote:
> numa_error("request to allocate mask for invalid number; abort\n");
> - return NULL;
> + exit(1);
My usual rule of thumb is that system libraries should not be printing
errors, and should not be exiting. One would not want a major user
level service process that happened to be linked with libnuma, deep
down in some corner, just going "poof". Libraries should return errors
in accordance with the interface they provide, and if the calling
application is too stupid to handle that error, then tough toenails.
Such libraries should also not issue unrequested output.
System libraries simply must not have unintended side affects ... such
as exits or unrequested file (stdout or stderr) output. In some narrow
example, for a particular use, such side affects might seem to make
sense, but once a major user space system service is up and running,
linked perhaps with several dozen such libraries that no one human even
knows about entirely, such side affects lead to unexpected behaviour.
The WEAK numa_error symbol provides a way out of the unintended output
problem, but it has the wrong default -- output unless the application
takes special actions to suppress that output.
Cliff -- where is the current libnuma source?
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.940.382.4214
--
To unsubscribe from this list: send the line "unsubscribe linux-numa" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
