Hi Jiapeng,
On Mon, Feb 7, 2022 at 7:37 PM Jiapeng Chong
<jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
>
> Clean up the following smatch warning:
>
> fs/nilfs2/segbuf.c:358 nilfs_segbuf_submit_bio() warn: ignoring
> unreachable code.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> fs/nilfs2/segbuf.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
> index 9e5dd6324ea1..50d7e2e4daed 100644
> --- a/fs/nilfs2/segbuf.c
> +++ b/fs/nilfs2/segbuf.c
> @@ -341,7 +341,6 @@ static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
> int mode_flags)
> {
> struct bio *bio = wi->bio;
> - int err;
>
> bio->bi_end_io = nilfs_end_bio_write;
> bio->bi_private = segbuf;
> @@ -354,9 +353,6 @@ static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
> wi->nr_vecs = min(wi->max_pages, wi->rest_blocks);
> wi->start = wi->end;
> return 0;
> -
> - wi->bio = NULL;
> - return err;
> }
Sorry for my late reply.
I will send this to Andrew to report and fix the regression on the -mm
patch series.
I'd like to change the patch title to something like "nilfs2: Remove
redundant code"
since the "mm/fs" prefix does not properly represent what it applies to.
(this patch may be folded into the patch that is causing the warning)
Regards,
Ryusuke Konishi
