Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
From: Benjamin Coddington <bcodding@xxxxxxxxxx>
Date: Wed, 07 Dec 2022 06:47:43 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, Paolo Abeni <pabeni@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Eric Dumazet <edumazet@xxxxxxxxxx>, Guillaume Nault <gnault@xxxxxxxxxx>
In-reply-to: <20221025111525.GA4415@localhost.localdomain>
References: <de6d99321d1dcaa2ad456b92b3680aa77c07a747.1665401788.git.gnault@redhat.com> <Y0QyYV1Wyo4vof70@infradead.org> <20221010165650.GA3456@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com> <Y0UKq62ByUGNQpuY@infradead.org> <20221011150057.GB3606@localhost.localdomain> <a0bf0d49a7a69d20cfe007d66586a2649557a30b.camel@kernel.org> <20221011211433.GA13385@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com> <20221013121834.GA3353@localhost.localdomain> <20221025111525.GA4415@localhost.localdomain>

On 25 Oct 2022, at 7:15, Guillaume Nault wrote:

> On Thu, Oct 13, 2022 at 02:18:37PM +0200, Guillaume Nault wrote:
>> Still, that looks like net-next material to me. Reverting sunrpc to use
>> GFP_NOFS looks better for an immediate bug fix.
>
> Could we please move forward with this patch? This bug really needs to be
> fixed. So please let's either revert to GFP_NOFS or actively work on a
> different solution.

Hey Trond, Anna - I think the right thing to do here is send this patch to
-stable as stable-only while we try to get this fixed up.  Any objections to
that?

Ben

References:
- [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Guillaume Nault
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Christoph Hellwig
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Guillaume Nault
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Christoph Hellwig
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Guillaume Nault
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Trond Myklebust
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Guillaume Nault
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Guillaume Nault
- Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
  - From: Guillaume Nault

Prev by Date: Re: [PATCH v2] fscache: Fix oops due to race with cookie_lru and use_cookie
Next by Date: [PATCH v2] fscache: Fix oops due to race with cookie_lru and use_cookie
Previous by thread: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
Next by thread: [PATCH] NFSD: Remove redundant assignment to variable host_err
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux USB Development] [Linux Media Development] [Video for Linux] [Linux NILFS] [Linux Audio Users] [Yosemite Info] [Linux SCSI]