On Mon, Oct 10, 2022 at 11:18:19PM -0700, Christoph Hellwig wrote: > On Mon, Oct 10, 2022 at 06:56:50PM +0200, Guillaume Nault wrote: > > That's what my RFC patch did. It was rejected because reading > > current->flags may incur a cache miss thus slowing down TCP fast path. > > See the discussion in the Link tag: > > https://lore.kernel.org/netdev/b4d8cb09c913d3e34f853736f3f5628abfd7f4b6.1656699567.git.gnault@xxxxxxxxxx/ > > As GFP_NOFS/NOIO are on their way out the networking people will have to > do this anyway. We can always think of a nicer solution in the future. But right now we have a real bug to fix. Commit a1231fda7e94 ("SUNRPC: Set memalloc_nofs_save() on all rpciod/xprtiod jobs") introduces a bug that crashes the kernel. I can't see anything wrong with a partial revert.
