> On Jan 31, 2022, at 5:20 PM, Jonathan Woithe <jwoithe@xxxxxxxxxx> wrote: > > On Wed, Jan 19, 2022 at 04:18:10PM +0000, Chuck Lever III wrote: >>> On Jan 18, 2022, at 5:00 PM, Bruce Fields <bfields@xxxxxxxxxxxx> wrote: >>> >>> From: "J. Bruce Fields" <bfields@xxxxxxxxxx> >>> >>> I thought I was iterating over the array when actually the iteration is >>> over the values contained in the array? >>> >>> Ugh, keep it simple. >>> >>> Symptoms were a null deference in vfs_lock_file() when an NFSv3 client >>> that previously held a lock came back up and sent a notify. >>> >>> Reported-by: Jonathan Woithe <jwoithe@xxxxxxxxxx> >>> Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file") >>> Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx> >>> --- >>> : >> Hi Bruce, thanks for the fixes. They've passed my basic smoke tests. >> I've applied both patches for the very next nfsd PR. See: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git for-next > > OOI, is it expected that these fixes will appear in a 5.15.x stable branch > patch at some point? I've looked at the 5.15.17 and 5.15.18 changelogs and > they don't appear to be mentioned yet. These are in linux-next right now. I intend to send a pull request this week. I was waiting for some other fixes, but those are not going as quickly as I hoped, so I'm going to send these two along with another fix that are all ready now. Once they are in v5.17-rc, they will be picked up automatically and applied to open stable branches. If they do not apply cleanly, then someone will have to construct and test a version of the fixes specifically for each of the stable branches. -- Chuck Lever