On Wed, Jan 19, 2022 at 04:18:10PM +0000, Chuck Lever III wrote: > > On Jan 18, 2022, at 5:00 PM, Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > > > > From: "J. Bruce Fields" <bfields@xxxxxxxxxx> > > > > I thought I was iterating over the array when actually the iteration is > > over the values contained in the array? > > > > Ugh, keep it simple. > > > > Symptoms were a null deference in vfs_lock_file() when an NFSv3 client > > that previously held a lock came back up and sent a notify. > > > > Reported-by: Jonathan Woithe <jwoithe@xxxxxxxxxx> > > Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file") > > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx> > > --- > > : > Hi Bruce, thanks for the fixes. They've passed my basic smoke tests. > I've applied both patches for the very next nfsd PR. See: > > git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git for-next OOI, is it expected that these fixes will appear in a 5.15.x stable branch patch at some point? I've looked at the 5.15.17 and 5.15.18 changelogs and they don't appear to be mentioned yet. Regards jonathan