On Wed, 26 Jan 2022, Chuck Lever III wrote: > > > On Jan 25, 2022, at 4:53 PM, NeilBrown <neilb@xxxxxxx> wrote: > > > > > > Could we rename svc_close_net() to svc_shutdown_net() and drop this > > function? > > I considered that, but svc_close_net() seems to be transport-related, > whereas svc_shutdown_net() seems to be generic to the NFS server, so > I left them separate. A better rationale might push me into merging > them. :-) > svc_close_net() is effectively the inverse of svc_create_xprt(), though the later can be called several times, and the former cleans up them all. So maybe rename svc_close_net() to svc_close_xprts() (plural), and call it from the places which currently call svc_close_net(). Those places (nfsd, lockd, nfs/callback) already call svc_create_xprt(). Having them explicitly call svc_close_xprts() to balance that would arguably make the code clearer. Thanks, NeilBrown
