On Thu, Jan 06, 2022 at 07:23:16AM +0000, inoguchi.yuki@xxxxxxxxxxx wrote: > > How about this? I also updated the lock/nolock description and deleted > > the end of this subsection since it's redundant with that. And removed > > the bit about using nolock to mount /var with v2/v3 as that seems like a > > bit of a niche case at this point. If we still want to document that, I > > think it belongs elsewhere. > > Thank you so much for creating the patch! > > For the most part I agree with you, but I feel unsafe to remove the part > "using nolock to mount /var with v2/v3" even if it seems niche case. > I'm also not sure if there is another suitable document to migrate it. > > Therefore, at the end of "lock/nolock" subsection ... I could live with that. Though the other reason I cut it was because I think it needs updates too and I wasn't sure exactly how to handle them. The v4 case is more important and should probably be dealt with first. I think the answer there is just "don't mount /var over NFSv4", period. And maybe we should be more specific: the problem is with /var/lib/nfs, not all of /var. --b. > > > @@ -733,16 +733,9 @@ but such locks provide exclusion only against other > > applications > > running on the same client. > > Remote applications are not affected by these locks. > > .IP > > -NLM locking must be disabled with the > > -.B nolock > > -option when using NFS to mount > > -.I /var > > -because > > -.I /var > > -contains files used by the NLM implementation on Linux. > > -Using the > > +The > > .B nolock > > -option is also required when mounting exports on NFS servers > > +option is required when using NFSv2 or NFSv3 to mount servers > > that do not support the NLM protocol. > > .TP 1.5i > > .BR cto " / " nocto > > ... can we keep the description like this ? > ----- > @@ -733,17 +733,14 @@ but such locks provide exclusion only against other applications > running on the same client. > Remote applications are not affected by these locks. > .IP > -NLM locking must be disabled with the > +When using NFSv2 or NFSv3, the > .B nolock > -option when using NFS to mount > -.I /var > -because > +option is required to mount servers that do not support the NLM protocol, > +or to mount > .I /var > +because > +.I /var > contains files used by the NLM implementation on Linux. > -Using the > -.B nolock > -option is also required when mounting exports on NFS servers > -that do not support the NLM protocol. > .TP 1.5i > .BR cto " / " nocto > Selects whether to use close-to-open cache coherence semantics. > ----- > Yuki Inoguchi
