On 29 Sep 2021, at 9:49, trondmy@xxxxxxxxxx wrote: > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > If a user is doing 'ls -l', we have a heuristic in GETATTR that tells > the readdir code to try to use READDIRPLUS in order to refresh the inode > attributes. In certain cirumstances, we also try to invalidate the > remaining directory entries in order to ensure this refresh. > > If there are multiple readers of the directory, we probably should avoid > invalidating the page cache, since the heuristic breaks down in that > situation anyway. Hi Trond, I'm curious about the motivation for this work because we're often managing expectations about performance between various workloads. What does the workload look like that prompted you to make this optimization? I'm also interested because I have some work that improves readdir performance for multiple readers on large directories, but is rotting because things have been "good enough" for folks over here. Ben
