Re: [PATCH 09/13] sunrpc: add a symlink from rpc-client directory to the xprt_switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Olga,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on nfsd/nfsd-next v5.12-rc7 next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210415-102946
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a05b7df960093f762cbe85580d90bd3d0b83d54b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210415-102946
        git checkout a05b7df960093f762cbe85580d90bd3d0b83d54b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   net/sunrpc/sysfs.c: In function 'rpc_sysfs_client_setup':
>> net/sunrpc/sysfs.c:164:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     164 |   int ret;
         |       ^~~


vim +/ret +164 net/sunrpc/sysfs.c

   151	
   152	void rpc_sysfs_client_setup(struct rpc_clnt *clnt,
   153				    struct rpc_xprt_switch *xprt_switch,
   154				    struct net *net)
   155	{
   156		struct rpc_sysfs_client *rpc_client;
   157	
   158		rpc_client = rpc_sysfs_client_alloc(rpc_sunrpc_client_kobj,
   159						    net, clnt->cl_clid);
   160		if (rpc_client) {
   161			char name[23];
   162			struct rpc_sysfs_xprt_switch *xswitch =
   163				(struct rpc_sysfs_xprt_switch *)xprt_switch->xps_sysfs;
 > 164			int ret;
   165	
   166			clnt->cl_sysfs = rpc_client;
   167			rpc_client->clnt = clnt;
   168			rpc_client->xprt_switch = xprt_switch;
   169			kobject_uevent(&rpc_client->kobject, KOBJ_ADD);
   170			snprintf(name, sizeof(name), "switch-%d", xprt_switch->xps_id);
   171			ret = sysfs_create_link_nowarn(&rpc_client->kobject,
   172						       &xswitch->kobject, name);
   173		}
   174	}
   175	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux