Re: [PATCH 11/13] sunrpc: add dst_attr attributes to the sysfs xprt directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Olga,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on nfsd/nfsd-next v5.12-rc7 next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210415-102946
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-s001-20210414 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-280-g2cd6d34e-dirty
        # https://github.com/0day-ci/linux/commit/c5b3ebaffb5ca80f6c6170e8ecd2dfc9494880bf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Olga-Kornievskaia/create-sysfs-files-for-changing-IP-address/20210415-102946
        git checkout c5b3ebaffb5ca80f6c6170e8ecd2dfc9494880bf
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
>> net/sunrpc/sysfs.c:56:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> net/sunrpc/sysfs.c:56:25: sparse:    struct rpc_xprt [noderef] __rcu *
>> net/sunrpc/sysfs.c:56:25: sparse:    struct rpc_xprt *
>> net/sunrpc/sysfs.c:56:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> net/sunrpc/sysfs.c:56:25: sparse:    struct rpc_xprt [noderef] __rcu *
>> net/sunrpc/sysfs.c:56:25: sparse:    struct rpc_xprt *

vim +56 net/sunrpc/sysfs.c

    47	
    48	static inline struct rpc_xprt *
    49	rpc_sysfs_xprt_kobj_get_xprt(struct kobject *kobj)
    50	{
    51		struct rpc_sysfs_xprt_switch_xprt *x = container_of(kobj,
    52			struct rpc_sysfs_xprt_switch_xprt, kobject);
    53		struct rpc_xprt *xprt;
    54	
    55		rcu_read_lock();
  > 56		xprt = xprt_get(rcu_dereference(x->xprt));
    57		rcu_read_unlock();
    58		return xprt;
    59	}
    60	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux