> On Nov 14, 2020, at 1:45 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Sat, Nov 14, 2020 at 01:26:43PM -0500, Chuck Lever wrote:
>>
>>
>>> On Nov 14, 2020, at 4:28 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>>>
>>>> +static __be32
>>>> +nfsd4_decode_access(struct nfsd4_compoundargs *argp, struct nfsd4_access *access)
>>>
>>> Please fix up a bunch of overly long lines here and in the other
>>> patches.
>>
>> Not saying no, but...
>>
>> Kernel coding style and scripts/checkpatch.pl were recently
>> updated to permit 100 character long lines. What reason is
>> there to shorten these?
>
> The coding style only allows it as an exception if it significantly
> improves readabily. and modern checkpatch.pl unfortunately is wrong
> more often than not.
So you would prefer:
static __be32 nfsd4_decode_access(struct nfsd4_compoundargs *argp,
struct nfsd4_access *access)
?
--
Chuck Lever
