Re: [PATCH v1 07/61] NFSD: Replace READ* macros in nfsd4_decode_close()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Sat, Nov 14, 2020 at 01:30:33PM -0500, Chuck Lever wrote:
> Question of coding style. Some people prefer having a single
> point of exit at the tail of a function.

While I've heard the argument of a single exit a few times, it was
usually from people that also frown upon goto labels and produces
strange deeply nested code..

> I suppose I could simplify these smaller decoders, but it's
> subjective. Anyone else have an opinion? Christoph, as an
> example, how would you express this particular function?

static __be32
nfsd4_decode_stateid4(struct nfsd4_compoundargs *argp, stateid_t *sid)
{
	__be32 *p;

	p = xdr_inline_decode(argp->xdr, NFS4_STATEID_SIZE);
	if (!p)
		return nfserr_bad_xdr;
	sid->si_generation = be32_to_cpup(p++);
	memcpy(&sid->si_opaque, p, sizeof(sid->si_opaque));
	return nfs_ok;
}