Olga Kornievskaia wrote: >On Thu, May 30, 2019 at 1:05 PM Tom Talpey <tom@xxxxxxxxxx> wrote: >> >> On 5/29/2019 8:41 PM, NeilBrown wrote: >> > I've also re-arrange the patches a bit, merged two, and remove the >> > restriction to TCP and NFSV4.x,x>=1. Discussions seemed to suggest >> > these restrictions were not needed, I can see no need. >> >> I believe the need is for the correctness of retries. Because NFSv2, >> NFSv3 and NFSv4.0 have no exactly-once semantics of their own, server >> duplicate request caches are important (although often imperfect). >> These caches use client XID's, source ports and addresses, sometimes >> in addition to other methods, to detect retry. Existing clients are >> careful to reconnect with the same source port, to ensure this. And >> existing servers won't change. > >Retries are already bound to the same connection so there shouldn't be >an issue of a retransmission coming from a different source port. I don't think the above is correct for NFSv4.0 (it may very well be true for NFSv3). Here's what RFC7530 Sec. 3.1.1 says: 3.1.1. Client Retransmission Behavior When processing an NFSv4 request received over a reliable transport such as TCP, the NFSv4 server MUST NOT silently drop the request, except if the established transport connection has been broken. Given such a contract between NFSv4 clients and servers, clients MUST NOT retry a request unless one or both of the following are true: o The transport connection has been broken o The procedure being retried is the NULL procedure If the transport connection is broken, the retry needs to be done on a new TCP connection, does it not? (I'm assuming you are referring to a retry of an RPC here.) (My interpretation of "broken" is "can't be fixed, so the client must use a different TCP connection.) Also, NFSv4.0 cannot use Sun RPC over UDP, whereas some DRCs only work for UDP traffic. (The FreeBSD server does have DRC support for TCP, but the algorithm is very different than what is used for UDP, due to the long delay before a retried RPC request is received. This can result in significant server overheads, so some sites choose to disable the DRC for TCP traffic or tune it in such a way as it becomes almost useless.) The FreeBSD DRC code for NFS over TCP expects the retry to be from a different port# (due to a new connection re: the above) for NFSv4.0. For NFSv3, my best recollection is that it doesn't care what the source port# is. (It basically uses a hash on the RPC request excluding TCP/IP header to recognize possible duplicates.) I don't know what other NFS servers choose to do w.r.t. the DRC for NFS over TCP, however for some reason I thought that the Linux knfsd only used a DRC for UDP? (Someone please clarify this.) rick > Multiple connections will result in multiple source ports, and possibly > multiple source addresses, meaning retried client requests may be > accepted as new, rather than having any chance of being recognized as > retries. > > NFSv4.1+ don't have this issue, but removing the restrictions would > seem to break the downlevel mounts. > > Tom. >
