On 3/7/19 10:01 AM, Richard Sharpe wrote: > On Wed, Mar 6, 2019 at 5:17 PM Richard Sharpe > <realrichardsharpe@xxxxxxxxx> wrote: >> >> When I installed Fedora-29 to check out building on Fedora I didn't >> have rpcgen installed. >> >> autogen worked and configure worked but make failed in spectacular ways. >> >> The attached patch warns the user during configure but is perhaps not >> the correct test, because of rpcgen is on your path but not where the >> earlier tests expect it, things will still likely fail. > > Here is a better version. Since we already know we didn't find rpcgen, > just let the user know. > > Tested by uninstalling rpcgen. Committed.... Sorry for taking so long but there was no [PATCH] in the subject line so I missed it... The format of looks good except there is no Signed-off-by line... just use the -s flag on the commit. Try using git send-email to post patches... It will do the right thing. steved. > > From 6caea95ccebb5d3635b3d1c91e8683954fe61645 Mon Sep 17 00:00:00 2001 > From: root <realrichardsharpe@xxxxxxxxx> > Date: Wed, 6 Mar 2019 19:51:12 -0500 > Subject: [PATCH] If we don't find rpcgen let the user know about it rather > than getting an error later during make. > > --- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index cb9d921..b23bb6a 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -154,6 +154,9 @@ AC_ARG_WITH(rpcgen, > if test "$rpcgen_path" = "yes"; then > for p in /usr/local/bin/rpcgen /usr/bin/rpcgen /bin/rpcgen > do if test -f $p ; then RPCGEN_PATH=$p ; break; fi ; done > + if test -z "$RPCGEN_PATH"; then > + AC_MSG_ERROR([Please install rpcgen or use --with-rpcgen]) > + fi > elif test "$rpcgen_path" != "internal"; then > RPCGEN_PATH=$rpcgen_path > else > -- > 2.19.1 > > >
