On Fri, Jul 20, 2018 at 2:50 PM, Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> wrote: > On Fri, 2018-07-20 at 14:44 -0400, Olga Kornievskaia wrote: >> Hi Trond, >> >> This is a different question but is related to the attribute >> handling. >> >> What I see in v4, is that say the client received a reply to the OPEN >> with before and after change_attr values for the directory. We check >> if the before value is the same as what we have in the cache and if >> it's not then we invalidate the directory attributes. >> >> It seems that we don't have similar check for the v3. If in v3, the >> server returned a before that was different from what could be seen >> on >> the network trace as the before for the directory, it does not >> trigger >> invalidation. Is this expected because it's v3 or is this a bug? > > Doesn't the call to nfs_post_op_update_inode(dir, data->res.dir_attr) > in nfs3_do_create() do the right thing? Dah, I knew I was missing something. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html