Hey, On 04/10/2018 06:29 PM, Chuck Lever wrote: > > >> On Apr 10, 2018, at 3:30 PM, Steve Dickson <steved@xxxxxxxxxx> wrote: >> >> Commit 46e04a73 changed svc_com_create() to avoid using >> reserve ports but removed the listen() call which >> could break, undocumented expectations, of legacy >> server apps. >> >> Reserve ports are not needed for listening ports, so >> the new __binddynport() is used to avoid squatting >> on ports that are assigned to other network services, >> but it is important to say backwards compatible >> with the legacy glibc code so the the listen() >> call is added back. > > svc_tli_create should already perform a call to __binddynport() > and to listen(2). That's why those calls were removed from > svc_com_create(). > Fair enough... I did miss that call to svc_tli_create(). It appears the callers of svc_com_create() are no longer used at least in nfs-utils. It appears to be the old SUN RPC API and we using the TIRPC API. steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
