> On Apr 10, 2018, at 3:30 PM, Steve Dickson <steved@xxxxxxxxxx> wrote:
>
> Commit 46e04a73 changed both clnt_com_create()
> and clnt_tli_create() to avoid using reserve ports when
> creating connection to the server.
>
> For certain legacy apps, the client has to used
> reserve port to be able to communicate with its
> server so using of reserve ports is restored.
Hi Steve-
Which legacy apps use clnt_tli_create and require this behavior?
There is no backwards compatibility requirement for this API.
> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
> ---
> src/clnt_generic.c | 3 +--
> src/rpc_soc.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/clnt_generic.c b/src/clnt_generic.c
> index e5a314f..774292b 100644
> --- a/src/clnt_generic.c
> +++ b/src/clnt_generic.c
> @@ -341,8 +341,7 @@ clnt_tli_create(int fd, const struct netconfig *nconf,
> servtype = nconf->nc_semantics;
> if (!__rpc_fd2sockinfo(fd, &si))
> goto err;
> - if (__binddynport(fd) == -1)
> - goto err;
> + bindresvport(fd, NULL);
> } else {
> if (!__rpc_fd2sockinfo(fd, &si))
> goto err;
> diff --git a/src/rpc_soc.c b/src/rpc_soc.c
> index af6c482..f32a27c 100644
> --- a/src/rpc_soc.c
> +++ b/src/rpc_soc.c
> @@ -147,8 +147,7 @@ clnt_com_create(raddr, prog, vers, sockp, sendsz, recvsz, tp, flags)
> bindaddr.maxlen = bindaddr.len = sizeof (struct sockaddr_in);
> bindaddr.buf = raddr;
>
> - if (__binddynport(fd) == -1)
> - goto err;
> + bindresvport(fd, NULL);
> cl = clnt_tli_create(fd, nconf, &bindaddr, prog, vers,
> sendsz, recvsz);
> if (cl) {
> --
> 2.14.3
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Libtirpc-devel mailing list
> Libtirpc-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/libtirpc-devel
--
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
