On Wed, Dec 06, 2017 at 12:14:41PM +0000, Al Viro wrote: > On Fri, Nov 17, 2017 at 11:45:47AM -0600, Joshua Watt wrote: > > The umount_end operation allows cleaning of state set by umount_begin in > > the event the filesystem doesn't actually get unmounted. > > The locking doesn't make any sense. This thing can come at *any* moment - > one process does this force-unmount of yours, another comes and accesses > the damn thing just as you've decided that umount has failed and go > to call that method. Consider, BTW, the situation when another umount -f comes just as you've dropped ->s_umount. Now your ->umount_end() comes *after* ->umount_begin() from the second call. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
