On Fri, Nov 17, 2017 at 11:45:47AM -0600, Joshua Watt wrote: > The umount_end operation allows cleaning of state set by umount_begin in > the event the filesystem doesn't actually get unmounted. The locking doesn't make any sense. This thing can come at *any* moment - one process does this force-unmount of yours, another comes and accesses the damn thing just as you've decided that umount has failed and go to call that method. In other words, filesystem can be accessed before and during that call. And that is not to mention the fact that in another namespace the same super_block might remain mounted through all of that, giving overlapping accesses during and after ->umount_begin(), so the latter can't do anything other than "try and kill those waiting on that fs" anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
