> On May 9, 2017, at 8:16 AM, Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> wrote: > >> On Tue, 2017-05-09 at 11:20 +0200, Christoph Hellwig wrote: >> pc_count is the only writeable memeber of struct svc_procinfo, which >> is >> a good candidate to be const-ified as it contains function pointers. >> >> This patch just removes it and returns zero in the /proc file as the >> count of calls per procedure doesn't seem all that useful.  But it's >> just a dumb hack and we might need a proper fix instead. >> >> Signed-off-by: Christoph Hellwig <hch@xxxxxx> >> --- >> > > For now, why not just move it to a separate non-const structure that is > pointed to by the const one? We shouldn't deliberately break nfsstat... Agree on both counts. > -- > Trond Myklebust > Linux NFS client maintainer, PrimaryData > trond.myklebust@xxxxxxxxxxxxxxx > N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±û"žØ^n‡r¡ö¦zËëh™¨èÚ&¢ø®G«éh®(階ŠÝ¢j"ú¶m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html