Re: [PATCH 29/32] RFC: sunrpc: remove pc_count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-05-09 at 11:20 +0200, Christoph Hellwig wrote:
> pc_count is the only writeable memeber of struct svc_procinfo, which
> is
> a good candidate to be const-ified as it contains function pointers.
> 
> This patch just removes it and returns zero in the /proc file as the
> count of calls per procedure doesn't seem all that useful.  But it's
> just a dumb hack and we might need a proper fix instead.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> 

For now, why not just move it to a separate non-const structure that is
pointed to by the const one? We shouldn't deliberately break nfsstat...

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux