Re: [Libtirpc-devel] [PATCH - rpcbind] Provide systemd unit files for rpcbind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 03 2016, Steve Dickson wrote:

> On 11/02/2016 09:49 AM, Thorsten Kukuk wrote:
>> On Wed, Nov 02, Steve Dickson wrote:
>> 
>>> I just took a look and we don't set that... Here is what we
>>> set in Fedora
>>>
>>> RPCBDIR=/tmp
>>> %configure CFLAGS="$CFLAGS" LDFLAGS="-pie" \
>>>     --enable-warmstarts \
>>>     --with-statedir="$RPCBDIR" \
>>>     --with-rpcuser="$RPCBUSR" \
>>>     --with-nss-modules="files altfiles" \
>>>     --enable-libwrap \
>>>     --enable-debug
>> 
>> The rpcbind Makefile has:
>> bin_PROGRAMS = rpcbind rpcinfo
>> 
>> So per default, "make install" should install it into /usr/bin
>> and the patch from Niel with bin is correct.
> You are correct... In  %install does the following
>
> mv -f ${RPM_BUILD_ROOT}%{_bindir}/rpcbind ${RPM_BUILD_ROOT}/sbin
> mv -f ${RPM_BUILD_ROOT}%{_bindir}/rpcinfo ${RPM_BUILD_ROOT}%{_sbindir}
>
> Since rpcbind lives in /usr/sbin in the majority distro
> I'm going to change the Makefile.am so "make install" 
> will do the right thing... Any objections?

If you do it by changing the default for bindir, or by introducing an
sbindir that can be changed with configure, then no objections from me.
I'm not sure it really needs fixing, but I don't object to be being
fixed.

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux