On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik <jbacik@xxxxxx> wrote: > > So my naive fix would be something like this Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look at it - all the other callers of fh_compose() also seem to just drop the dentry unconditionally, knowing that fh_compose() took a ref to it if needed. In fact, the only thing I'd do differently would be to not even put the comment there at all, since this call site isn't any different from any of the others. If anything, it could go on fh_compose() if we want to add comments. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html