On Wed, Aug 10, 2016 at 11:56:15AM -0700, Linus Torvalds wrote: > On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik <jbacik@xxxxxx> wrote: > > > > So my naive fix would be something like this > > Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look > at it - all the other callers of fh_compose() also seem to just drop > the dentry unconditionally, knowing that fh_compose() took a ref to it > if needed. > > In fact, the only thing I'd do differently would be to not even put > the comment there at all, since this call site isn't any different > from any of the others. If anything, it could go on fh_compose() if we > want to add comments. Yep, makes sense to me too. OK with me if you want to take it, otherwise I'll run it through my usual tests and send you a pull request probably today or tomorrow. Thanks, Josef! (And kernel test robot folks--the speed with which they're catching stuff, and bisecting down to individual commits, is really amazing to me.) --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
