Re: [RFC 0/2] Sharing flex file XDR encoding between client and server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 07, 2016 at 04:34:44PM -0700, Tom Haynes wrote:
> This builds on my prior change set for the flex file server.
> 
> I'm not too hot on putting this much code in a header, but
> I can't think of a cleaner way without leaking too much
> between the client and server.
> 
> Any guidance on how this is typically approached?

Looks like there's some cut-and-paste from net/sunrpc/addr.c.  Any
reason not to just use those functions and/or add any necessary new
stuff there?

--b.

> 
> Thanks,
> Tom
> 
> 
> Tom Haynes (2):
>   nfs: Encoding a netaddr is common to client and server
>   nfsd: Encode a netaddr correctly
> 
>  fs/nfs/flexfilelayout/flexfilelayout.c |  93 +-----------------------------
>  fs/nfs/flexfilelayout/flexfilelayout.h |   5 +-
>  fs/nfsd/flexfilelayout.c               |  26 +--------
>  fs/nfsd/flexfilelayoutxdr.c            |  34 +++++------
>  fs/nfsd/flexfilelayoutxdr.h            |  15 +----
>  include/linux/nfs4_ff.h                | 100 +++++++++++++++++++++++++++++++++
>  6 files changed, 120 insertions(+), 153 deletions(-)
>  create mode 100644 include/linux/nfs4_ff.h
> 
> -- 
> 2.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux