Re: [PATCH 0/3] fix backchannel crash due to multipath

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 6/13/16, 14:21, "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote:

>On March 24 J. Bruce Fields said:
>> pynfs can crash the nfs server since the new multipath code.  The
>> problem is that pynfs uses the same tcp connection for multiple v4
>> clients (something the spec explicitly allows).  The callback client in
>> such cases has to share the same rpc_xprt.  The new rpc code, when it
>> creates two callback clients sharing the same rpc_xprt, ends up trying
>> to keep that rpc_xprt on the lists of two different rpc_xprt_switch's.
>> The first symptom I see is a list corruption warning.
>>
>> So, I'm enforcing the requirement that there be only one backchannel
>> rpc_xprt_switch per tcp connection by doing as we do in the rpc_xprt
>> case: keeping a pointer to it in the svc_xprt, and using that when it's
>> available instead of allocating a new one.
>
>> That's a pretty straightforward fix (and I've verified it works), but
>> doesn't look very elegant.  If there's a better solution, I'm all ears.
>
>I haven't come up with anything neater, and kind of need the crash
>fixed.  ACK or NACK?  I can take it through my tree if it's an ACK.
>
>--b.
>

Ack

��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux