Now we have ro_unmap_safe() which sorta implies that there is a non-safe unmap? Why not just keep it ro_umap? Otherwise looks fine, Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html