Re: [PATCH v3 01/10] NFS4: remove a redundant lock range check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 28 Dec 2015 11:27:57 -0500
Benjamin Coddington <bcodding@xxxxxxxxxx> wrote:

> flock64_to_posix_lock() is already doing this check
> 
> Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx>
> ---
>  fs/nfs/nfs4proc.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 8981803..2231d7d 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -6108,9 +6108,6 @@ nfs4_proc_lock(struct file *filp, int cmd, struct file_lock *request)
>  	ctx = nfs_file_open_context(filp);
>  	state = ctx->state;
>  
> -	if (request->fl_start < 0 || request->fl_end < 0)
> -		return -EINVAL;
> -
>  	if (IS_GETLK(cmd)) {
>  		if (state != NULL)
>  			return nfs4_proc_getlk(state, F_GETLK, request);

Reviewed-by: Jeff Layton <jeff.layton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux