Re: [PATCH v1 03/24] IB/mlx5: Support the new memory registration API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/23/2015 12:27 AM, Bart Van Assche wrote:
On 09/17/2015 02:42 AM, Sagi Grimberg wrote:
+static int
+mlx5_alloc_priv_descs(struct ib_device *device,
+              struct mlx5_ib_mr *mr,
+              int ndescs,
+              int desc_size)
+{
+    int size = ndescs * desc_size;
+
+    mr->descs = dma_alloc_coherent(device->dma_device, size,
+                       &mr->desc_map, GFP_KERNEL);
+    if (!mr->descs)
+        return -ENOMEM;
+
+    return 0;
+}

Would it be possible to clarify the choice for coherent memory ?

No specific reason. I was just copying  alloc_fastreg_page_list logic.

Would performance be better if non-coherent memory would be used and if memory
would be synced after initialization of desc_map has finished ?

It probably would I assume. I'll change that.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux