Re: [PATCH v1 01/24] IB/core: Introduce new fast registration API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/23/2015 12:21 AM, Bart Van Assche wrote:
On 09/17/2015 02:42 AM, Sagi Grimberg wrote:
The new fast registration  verg ib_map_mr_sg receives a scatterlist

                              ^ verb ?

Will fix. Thanks.


+/**
+ * ib_map_mr_sg() - Map a memory region with the largest prefix of
+ *     a dma mapped SG list

This description could be made more clear. How about the following:

Register the largest possible prefix of a DMA-mapped SG-list

+            } else if (last_page_off + dma_len < mr->page_size) {
+                /* chunk this fragment with the last */
+                last_end_dma_addr += dma_len;
+                last_page_off += dma_len;
+                mr->length += dma_len;
+                continue;

Shouldn't this code update last_page_addr ?

Actually I think it doesn't since it is only relevant for the else
statement where we are passing the page_size boundary.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux