On Wed, Aug 26, 2015 at 04:31:09PM +0800, Peng Tao wrote: > >> -#define BTRFS_IOC_CLONE _IOW(BTRFS_IOCTL_MAGIC, 9, int) > > > > The ioctl definition reuses the BTRFS_IOCTL_MAGIC (0x94), which is IMHO > > wrong. > > > I thought it breaks ABI if we choose a different value for the type > field of the ioctl. Am I misunderstanding it? The ioctl is now private to btrfs, you're going to define the new ABI so it IMHO should use the generic filesystem ioctl magic/namespace. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html