Re: [PATCH v2 03/18] nfsd: convert laundry_wq to something less nfsd4 specific

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 09, 2015 at 07:11:37AM -0400, Jeff Layton wrote:
> create_singlethread_workqueue already makes an unbound workqueue. This
> patch just lifts the "max_active" value to the default, and removes the
> WQ_MEM_RECLAIM flag.
> 
> We certainly could turn this into a bound workqueue, but given the sort
> of job that the laundromat runs I'm not sure we'd benefit much from the
> locality.
> 
> ...and sure, I can turn this into two patches if you'd prefer.

The patch was just rather confusing to me.  Do you want the existing
laundromat to scale better with lots of namespaces?  Sounds reasonable,
but I don't really see the use case.  

Looking at the later patches I now see you're overloading a totally
different job to it.  I don't think there's a point given how cheap
workqueues are these days.  Even more it seems like you really should
use the mm/list_lru.c infrastructure and a shrinker for a your file
cache.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux