On Sun, 9 Aug 2015 00:14:38 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Wed, Aug 05, 2015 at 05:13:21PM -0400, Jeff Layton wrote: > > Currently, nfsd uses a singlethread workqueue for this, but that's not > > necessary. If we have multiple namespaces, then there's no need to > > serialize the laundromat runs since they are only requeued at the end of > > the work itself. > > > > Also, create_singlethread_workqueue adds the WQ_MEM_RECLAIM flag, which > > doesn't really seem to be necessary. The laundromat jobs are always > > kicked off via a timer, and not from memory reclaim paths. There's no > > need for a rescuer thread. > > Why would you change it to an unbound WQ? I'd really prefer to split > the change of workqueue semantics and making it globall available, too. create_singlethread_workqueue already makes an unbound workqueue. This patch just lifts the "max_active" value to the default, and removes the WQ_MEM_RECLAIM flag. We certainly could turn this into a bound workqueue, but given the sort of job that the laundromat runs I'm not sure we'd benefit much from the locality. ...and sure, I can turn this into two patches if you'd prefer. -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
