On May 5, 2015, at 1:32 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Mon, May 04, 2015 at 03:17:25PM -0400, Chuck Lever wrote: >> This isn?t a problem for TCP because both client and server side >> TCP socket support are built into the sunrpc.ko module. The client and >> server RDMA transport support are in separate modules. > > A little offtopic, but at least the code structure is a nightmare for > TCP as well where we have a file like bc_svc.c which only has a single > function (bc_send), that happens to be called from backchannel-specific code > in svc.c just to call into a function in clnt.c that is entirely > backchannel-specific as well. Of course due to the lack of separate > modules that at least doesn't cause problems for users. bc_svc.c struck me as left over from a prototype. It would be reasonable to move bc_send into xprtsock.c (or some other convenient file) and then pass its address into the server code via a virtual function (eg. as an rpc_xprt op). I’ve been scratching my head wondering why we have still have CONFIG_SUNRPC_BACKCHANNEL, which is not exposed in menuconfig. Is it time to remove it? -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
