On Thu, Jan 15, 2015 at 12:55:35AM +0800, Peng Tao wrote: > > The right fix is to determine the O_DIRECT flag in one place when > > entering a write, and then pass it down on the stack. We already do > > this in XFS for example, it just needs to be expanded to filemap.c > > so that more filesystems benefit from it. > NFS hijacks DIO in ->write_iter by checking O_DIRECT flag and rely on > generic_file_write_iter() for buffer write. generic_file_write_iter() > again checks for O_DIRECT flag.... It seems that we can avoid the > double check on O_DIRECT flag by calling generic_perform_write() > instead. Yes, that sounds like the simplest version for now. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
