On 01/13/2015 02:42 PM, Tom Haynes wrote: > On Tue, Jan 13, 2015 at 02:15:04PM -0500, Anna Schumaker wrote: >> Hi Tao, >> >> On 01/06/2015 07:28 PM, Tom Haynes wrote: >>> From: Peng Tao <tao.peng@xxxxxxxxxxxxxxx> >>> >>> - lrp->args.iomode = iomode; >>> + lrp->args.range.iomode = iomode; >>> + lrp->args.range.offset = offset; >>> + lrp->args.range.length = length; >> >> Callers of pnfs_send_layoutreturn() are always passing offset = 0 and length = NFS4_MAX_UINT64. Can we have pnfs_send_layoutreturn() always set these values, rather than passing them as function parameters? >> > > Hi Anna, > > This is future-proofing - i.e., add the parameters such > that when we allow only returning part of the file we > already have the support in place. I still think we should hold off until partial file returns are added, making it less likely that somebody will introduce a bug in the meantime. Anna > > Thanks, > Tom > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
